Feature/multiphase material #675
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## develop #675 +/- ##
===========================================
+ Coverage 96.62% 96.66% +0.03%
===========================================
Files 123 122 -1
Lines 25318 25352 +34
===========================================
+ Hits 24463 24504 +41
+ Misses 855 848 -7
Continue to review full report at Codecov.
|
kks32
requested changes
Jul 22, 2020
ezrayst
reviewed
Jul 23, 2020
kks32
reviewed
Jul 23, 2020
kks32
approved these changes
Jul 24, 2020
|
@kks32 I added another enhancement in the |
tianchiTJ
approved these changes
Jul 24, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Describe the PR
This PR added an enhancement to deal with multiphase material initialization from file, which is essential for
two_phase_particleeither in explicit or implicit solver, or later onthree_phase_particle. The current proposal will work ok with MPI transfer or read from hdf5 for the single-phaseparticleas I am using a default phase argument to be solid. However, hdf5 initialization and MPI transfer process for two-phase is not yet implemented. This should be integrated after we find an approach to deal with multiphase hdf5 output (@kks32 is investigating that).Related Issues/PRs
#633
Additional context
I also added a small modification of pressure smoothing. @tianchiTJ @WeijianLiang Can we store
pore_pressureas a state variable in the fluid material? By doing so, we can use the same smoothing routine as we use in the single-phasepressure.